Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: navsan <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-25-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-25-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep issue #25: Move createNewBlock() out of the critical sec...
Content-Type: text/plain
Message-Id: <20160611034530.A3C0ADFC6C@git1-us-west.apache.org>
Date: Sat, 11 Jun 2016 03:45:30 +0000 (UTC)
archived-at: Sat, 11 Jun 2016 03:45:37 -0000

Github user navsan commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/25
  
    Harshad confirmed that it doesn’t break anything for BlockPoolInsertDestination. I’m not sure about the others. 
    
    
    > On Jun 10, 2016, at 22:39, Zuyu ZHANG <notifications@github.com> wrote:
    > 
    > @navsan <https://github.com/navsan> I thought you had confirmed that we don't need the critical section when creating a block. OK, let me check it.
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub <https://github.com/apache/incubator-quickstep/pull/25#issuecomment-225334606>, or mute the thread <https://github.com/notifications/unsubscribe/ACZB62ak34eGQ3QHfBVRArlFQi3JHMELks5qKi4AgaJpZM4IzdWM>.
    > 
    

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---