Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-14-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-14-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Content-Type: text/plain
Message-Id: <20160610223853.3EB52DFC4F@git1-us-west.apache.org>
Date: Fri, 10 Jun 2016 22:38:53 +0000 (UTC)
archived-at: Fri, 10 Jun 2016 22:38:59 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66690499
  
    --- Diff: query_execution/QueryContext.proto ---
    @@ -54,4 +54,6 @@ message QueryContext {
     
       // NOTE(zuyu): For UpdateWorkOrder only.
       repeated UpdateGroup update_groups = 10;
    +
    +  required uint64 query_id = 11;
    --- End diff --
    
    Since we add a new field in `QueryContext` proto, we need to modify `QueryContext::ProtoIsValid` to reflect the change:
    
    ```
      return proto.IsInitialized();
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---