Mailing-List: contact dev-help@quickstep.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@quickstep.incubator.apache.org
From: zuyu <git@git.apache.org>
To: dev@quickstep.incubator.apache.org
Reply-To: dev@quickstep.incubator.apache.org
References: <git-pr-8-incubator-quickstep@git.apache.org>
In-Reply-To: <git-pr-8-incubator-quickstep@git.apache.org>
Subject: [GitHub] incubator-quickstep pull request #8: Added query id in all the operators and...
Content-Type: text/plain
Message-Id: <20160606212231.BB371DFE5F@git1-us-west.apache.org>
Date: Mon,  6 Jun 2016 21:22:31 +0000 (UTC)
archived-at: Mon, 06 Jun 2016 21:22:36 -0000

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/8#discussion_r65971710
  
    --- Diff: relational_operators/WorkOrder.hpp ---
    @@ -286,8 +286,15 @@ class WorkOrder {
       }
     
      protected:
    -  WorkOrder() {}
    +  /**
    +   * @brief Constructor.
    +   *
    +   * @param query_id The ID of the query to which this WorkOrder belongs.
    +   **/
    +  explicit WorkOrder(const std::size_t query_id = 0)
    --- End diff --
    
    What do you think if we removed the default value for `query_id`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---