quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #34: Bug fixed in \analyze command and reus...
Date Wed, 15 Jun 2016 19:20:49 GMT
GitHub user hbdeshmukh opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/34

    Bug fixed in \analyze command and reuse code.

    The ``\analyze`` command issues SQL queries. Due to a recent change in the execution engine
(PR #14), there was a bug in issuing the queries, which is fixed in this branch. The issue
is described below:
    
    The workflow to issue queries is as follows:
    
    1. Create a TMB message consisting of the query. 
    2. Send the TMB message from main thread to the Foreman thread.
    3. Foreman executes the query.
    4. Foreman sends a completion message back to the main thread.
    5. Main thread receives the completion message and proceeds. 
    
    In the relevant function where ``\analyze`` queries are issued, we were not capturing
the response in step 5, which gave a segmentation fault sometimes. 
    
    This branch also puts a common code to receive feedback from Foreman upon query completion
in a function, which gets used in multiple places. There are some minor inclusion fixes in
the touched files.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep analyze-bugfix-and-refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit a7013627ecfab78aa80b483ee7f910ef7ea014d9
Author: Harshad Deshmukh <hbdeshmukh@apache.org>
Date:   2016-06-15T19:10:43Z

    Bug fixed in \analyze command and reuse code.
    
    - The \analyze command issues SQL queries. Due to a recent change in the
      execution engine, there was a bug in issuing the queries, which is
      fixed in this branch.
    - Reuse code to receive feedback from Foreman upon query completion.
    - Minor inclusion fixes in touched files.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message