quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #32: QUICKSTEP-21 Measure execution time of...
Date Tue, 14 Jun 2016 19:38:08 GMT
GitHub user hbdeshmukh opened a pull request:

    https://github.com/apache/incubator-quickstep/pull/32

    QUICKSTEP-21 Measure execution time of normal WorkOrders.

    This PR includes the following changes: 
    
    - Measure normal work order execution time
    - Split the WorkOrderCompletion proto message in two: Normal and Rebuild work orders.
    - Add execution time field in the NormalWorkOrderComplete proto message.
    - Include the recorded time in NormalWorkOrderComplete proto message that is sent back
to Foreman.
    
    Note that I didn't add the execution time field in RebuildWorkOrder completion message
because rebuilding storage block is pretty cheap for the storage layouts used by default.
Therefore the time taken by rebuild work order is quite low. If in the future, we need this
time, we can easily add it.
    
    Also note that, the CPU overhead for measuring this time is pretty low. In terms of memory,
we pay a cost of an additional 8 bytes in each completion message (only for normal work orders)
sent from each worker to the Foreman. 
    
    This feature can be quite helpful for performance monitoring. We can take a look at individual
work order execution time of different operators. I am planning to create another PR which
can produce reports consisting of average/max/min/variance of execution times grouped by different
operators. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-quickstep record-wo-execution-time

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quickstep/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit ba57e68333527e2a9c4376ab784beb42630887e2
Author: Harshad Deshmukh <hbdeshmukh@apache.org>
Date:   2016-06-14T19:02:45Z

    Measure execution time of normal WorkOrders.
    
    - Measure normal work order execution time
    - Split the WorkOrderCompletion proto message in two: Normal and Rebuild
      work orders.
    - Add execution time field in the NormalWorkOrderComplete proto message.
    - Include the recorded time in NormalWorkOrderComplete proto message
      that is sent back to Foreman.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message