quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Navneet Potti <nav...@gmail.com>
Subject Re: Code Style Guidelines and Code Review pages added to ASF wiki
Date Sun, 12 Jun 2016 04:40:59 GMT
Yeah, but I’m wondering if, using a git hook, we can automate away all formatting checks,
so that we don’t spend so much time commenting/discussing/arguing about formatting changes
in the PRs.


> On Jun 11, 2016, at 23:03, Jignesh Patel <jipatel@pivotal.io> wrote:
> 
> Hi Nav,
> 
> We do have one that is run automatically in .travis.yml. One can also run it manually
as: 
> 
> 	./third_party/cpplint/lint_everything.py
> 
> Cheers,
> Jignesh 
> 
>> On Jun 11, 2016, at 7:39 PM, Navneet Potti <navsan@gmail.com> wrote:
>> 
>> We may have discussed this in the past, but have we considered running clang-format
(with a suitably modified style file based on google-style-guide) as a pre-push git-hook?
>> 
>> 
>>> On Jun 11, 2016, at 19:17, Jignesh Patel <jmp.quickstep@gmail.com> wrote:
>>> 
>>> Folks: Added two pages to the ASF wiki under the How-to page. You can visit them
by going here: 
>>> 
>>> 
>>> 
>>> https://cwiki.apache.org/confluence/display/QUICKSTEP/How-to+articles
>>> 
>>> 
>>> 
>>> Comments welcome! 
>>> 
>>> 
>>> 
>>> Cheers,
>>> 
>>> Jignesh  
>>> 
>> 
> 


Mime
View raw message