quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From navsan <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #43: Remove unused AlwaysCreateBlockInsertDestinat...
Date Wed, 29 Jun 2016 18:17:24 GMT
Github user navsan commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/43
  
    Hi @hbdeshmukh, I've made the corresponding change to the .proto file. 
    
    On the `always_mark_full` flag: I agree that it doesn't seem to be used anywhere. But
is it directly related to the `AlwaysCreateBlockInsertDestination`? I didn't see any comments
explaining why this flag was added, and the flag is part of the `InsertDestination` interface.
Just to be safe, I've made the change in a separate commit, rather than squashing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message