quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #40: Minor Change: Added move constructor in optim...
Date Mon, 27 Jun 2016 21:13:57 GMT
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/40
  
    The title is misleading, please change to `Use move semantics when constructing optimizer::logical::Sort`,
since we are not adding a move constructor, but adding a new constructor w/ some rvalue arguments.
    
    Also, we need another separate PR for `WindowPlan`, as discussed in [here](https://github.com/apache/incubator-quickstep/pull/39#discussion_r68328569).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message