quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jianqiao <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #40: Minor Change: Added move constructor i...
Date Mon, 27 Jun 2016 19:44:08 GMT
Github user jianqiao commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/40#discussion_r68642507
  
    --- Diff: query_optimizer/logical/Sort.hpp ---
    @@ -137,6 +150,19 @@ class Sort : public Logical {
         addChild(input_);
       }
     
    +  Sort(const LogicalPtr &input,
    +       const std::vector<expressions::AttributeReferencePtr> &&sort_attributes,
    +       const std::vector<bool> &&sort_ascending,
    +       const std::vector<bool> &&nulls_first_flags,
    +       const int limit)
    +      : input_(input),
    +        sort_attributes_(std::move(sort_attributes)),
    +        sort_ascending_(std::move(sort_ascending)),
    +        nulls_first_flags_(std::move(nulls_first_flags)),
    +        limit_(limit) {
    +    addChild(input_);
    +  }
    --- End diff --
    
    Remove `const` for all rvalue reference (`&&`) arguments, otherwise it is not
really doing the move construction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message