quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #39: QUICKSTEP-20: Resolver support for Win...
Date Thu, 23 Jun 2016 23:01:19 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/39#discussion_r68330476
  
    --- Diff: query_optimizer/resolver/Resolver.cpp ---
    @@ -973,8 +1011,36 @@ L::LogicalPtr Resolver::resolveSelect(
             logical_plan, resolvePredicate(parse_predicate, &expr_resolution_info));
       }
     
    +  // Resolve WINDOW clause.
    +  std::unordered_map<std::string, WindowPlan> sorted_window_map;
    +  if (select_query.window_list() != nullptr) {
    +    if (select_query.window_list()->size() > 1) {
    +      THROW_SQL_ERROR_AT(&(*select_query.window_list()->begin()))
    +        << "Currently we don't support multiple window aggregation functions";
    --- End diff --
    
    Code style: add two more whitespace indentations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message