quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rogersjeffreyl <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #38: QUICKSTEP_25 PRIORITY clause in SQL st...
Date Fri, 17 Jun 2016 22:00:49 GMT
Github user rogersjeffreyl commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/38#discussion_r67581435
  
    --- Diff: parser/preprocessed/SqlLexer_gen.cpp ---
    @@ -8,8 +8,8 @@
     
     #define FLEX_SCANNER
     #define YY_FLEX_MAJOR_VERSION 2
    -#define YY_FLEX_MINOR_VERSION 6
    -#define YY_FLEX_SUBMINOR_VERSION 0
    +#define YY_FLEX_MINOR_VERSION 5
    --- End diff --
    
    The master branch lists 2.5.38 as  the minimum requirement for the FLEX version. So any
version > than that should  be fine. However, there is a TODO  
     # TODO(chasseur): This might not be the exact version to test for.
      if (FLEX_VERSION VERSION_GREATER 2.5.38)
    We might need to get this fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message