quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shixuan-fan <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #35: QUICKSTEP-20: Added Parser support for...
Date Fri, 17 Jun 2016 14:23:52 GMT
Github user shixuan-fan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/35#discussion_r67518021
  
    --- Diff: parser/ParseWindow.hpp ---
    @@ -0,0 +1,204 @@
    +/**
    + *   Copyright 2016, Quickstep Research Group, Computer Sciences Department,
    + *     University of Wisconsin—Madison.
    + *
    + *   Licensed under the Apache License, Version 2.0 (the "License");
    + *   you may not use this file except in compliance with the License.
    + *   You may obtain a copy of the License at
    + *
    + *       http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing, software
    + *   distributed under the License is distributed on an "AS IS" BASIS,
    + *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *   See the License for the specific language governing permissions and
    + *   limitations under the License.
    + **/
    +
    +#ifndef QUICKSTEP_PARSER_PARSE_WINDOW_HPP_
    +#define QUICKSTEP_PARSER_PARSE_WINDOW_HPP_
    +
    +#include <string>
    +#include <vector>
    +
    +#include "parser/ParseExpression.hpp"
    +#include "parser/ParseLiteralValue.hpp"
    +#include "parser/ParseOrderBy.hpp"
    +#include "parser/ParseTreeNode.hpp"
    +#include "utility/PtrList.hpp"
    +
    +#include "glog/logging.h"
    +
    +namespace quickstep {
    +
    +/**
    + * @brief The information of the how the framing in the window is defined
    + **/
    +struct ParseFrameInfo : ParseTreeNode {
    +  /**
    +   * @brief Constructor.
    +   * @param row True if the frame mode is ROW, false if it is RANGE.
    +   * @param num_pre The number of rows/value of range that is preceding
    +   *                the current row in the frame.
    +   * @param num_follow The number of rows/value of range that is following
    +   *                   the current row in the frame.
    +   **/  
    +  ParseFrameInfo(const int line_number,
    +                 const int column_number,
    +                 bool row,
    +                 long num_pre,
    +                 long num_follow)
    --- End diff --
    
    Will add "const". Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message