quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #35: QUICKSTEP-20: Added Parser support for...
Date Fri, 17 Jun 2016 04:43:06 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/35#discussion_r67460045
  
    --- Diff: query_optimizer/resolver/Resolver.cpp ---
    @@ -2366,6 +2367,12 @@ E::ScalarPtr Resolver::resolveFunctionCall(
         ExpressionResolutionInfo *expression_resolution_info) {
       std::string function_name = ToLower(parse_function_call.name()->value());
     
    +  // TODO(Shixuan): Add support for window aggregation function
    --- End diff --
    
    Code style: Please add a period in the end of the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message