quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #35: QUICKSTEP-20: Added Parser support for...
Date Fri, 17 Jun 2016 04:28:41 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/35#discussion_r67459445
  
    --- Diff: parser/ParseBasicExpressions.hpp ---
    @@ -429,6 +430,46 @@ class ParseFunctionCall : public ParseExpression {
         return star_.get();
       }
     
    +  /**
    +   * @return The window name.
    +   **/
    +  const ParseString* window_name() const {
    +    return window_name_.get();
    +  }
    +
    +  /**
    +   * @return The window.
    +   **/
    +  const ParseWindow* window() const {
    +    return window_.get();
    +  }
    +
    +  /**
    +   * @brief Check if this function is a window aggregation function
    +   *
    +   * @return True if this function is a window aggregation function; False
    +   *         otherwise.
    +   **/
    +  bool isWindow() const {
    +    return window_name_ != nullptr || window_ != nullptr;
    +  }
    +
    +  /**
    +   * @brief Set the window name.
    +   * @param window_name The window name.
    +   **/
    +  void setWindowName(ParseString *window_name) {
    +    window_name_.reset(std::move(window_name));
    +  }
    +
    +  /**
    +   * @brief Set the window.
    +   * @param window The window.
    +   **/
    +  void setWindow(ParseWindow *window) {
    +    window_.reset(std::move(window));
    --- End diff --
    
    Ditto for `move`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message