quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #33: BugFix: Update NumQueuedWorkOrders to ...
Date Wed, 15 Jun 2016 03:42:11 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/33#discussion_r67095580
  
    --- Diff: query_execution/PolicyEnforcer.hpp ---
    @@ -60,12 +61,14 @@ class PolicyEnforcer {
                      const std::size_t num_numa_nodes,
                      CatalogDatabaseLite *catalog_database,
                      StorageManager *storage_manager,
    -                 tmb::MessageBus *bus)
    +                 tmb::MessageBus *bus,
    +                 WorkerDirectory *worker_directory)
    --- End diff --
    
    This is optional, but I would suggest to move `worker_directory` before `bus` under the
idea that puts all third party stuff last.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message