quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #27: QUICKSTEP-18: Allow BasicColumnStoreTu...
Date Tue, 14 Jun 2016 16:54:00 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/27#discussion_r67010440
  
    --- Diff: storage/BasicColumnStoreTupleStorageSubBlock.hpp ---
    @@ -211,11 +213,12 @@ class BasicColumnStoreTupleStorageSubBlock : public TupleStorageSubBlock
{
                             const tuple_id distance);
     
       // Sort all columns according to ascending order of values in the sort
    -  // column. Returns true if any reordering occured.
    +  // column. Returns true if any reordering occured. This should only be called
    +  // when 'sort_specified_' is true, otherwise the block is always "built".
       bool rebuildInternal();
     
       tuple_id max_tuples_;
    -  bool sorted_;
    +  bool sort_specified_, sorted_;
    --- End diff --
    
    Since we set `sort_specified_` in the constructor's initialization list, we could mark
`const`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message