quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From craig-chasseur <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #27: QUICKSTEP-18: Allow BasicColumnStoreTu...
Date Tue, 14 Jun 2016 06:58:07 GMT
Github user craig-chasseur commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/27#discussion_r66917331
  
    --- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
    @@ -473,10 +483,10 @@ void BasicColumnStoreTupleStorageSubBlock::setAttributeValueInPlaceTyped(
     bool BasicColumnStoreTupleStorageSubBlock::deleteTuple(const tuple_id tuple) {
       DEBUG_ASSERT(hasTupleWithID(tuple));
     
    -  if (!column_null_bitmaps_.elementIsNull(sort_column_id_)) {
    -    if (column_null_bitmaps_[sort_column_id_].getBit(tuple)) {
    -      --(header_->nulls_in_sort_column);
    -    }
    +  if (sort_specified_
    +      && !column_null_bitmaps_.elementIsNull(sort_column_id_)
    +      && column_null_bitmaps_[sort_column_id_].getBit(tuple)) {
    --- End diff --
    
    That's not the style used in this file, nor in the rest of Quickstep generally. See lines
154 and 526 in the same file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message