quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pateljm <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #25: DO NOT MERGE: Move createNewBlock() out of th...
Date Tue, 14 Jun 2016 00:51:17 GMT
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/25
  
    @navsan This does look good to me. The logic makes sense as the mutex there is protecting
`available_block_refs_` and `available_block_ids_`, so seems ok to move the new memory allocation
outside. One request is to write comments in that function to make the intent clear -- this
way if there are issues in the future it will be easier to figure things out. A unit test
would be awesome too (as you suggested to me earlier today). 
    
    Thanks a lot for doing this!  
    
    @craig-chasseur -- any comments? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message