quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From navsan <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.
Date Mon, 13 Jun 2016 19:23:45 GMT
Github user navsan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/28#discussion_r66851286
  
    --- Diff: cli/QuickstepCli.cpp ---
    @@ -150,6 +154,14 @@ DEFINE_bool(initialize_db, false, "If true, initialize a database.");
     DEFINE_bool(print_query, false,
                 "Print each input query statement. This is useful when running a "
                 "large number of queries in a batch.");
    +DEFINE_string(profile_file_name, "",
    --- End diff --
    
    Thanks @hbdeshmukh for those suggestions. I'm not sure I completely agree with them, but
before we discuss them, are you suggesting that we make these changes in the current PR or
put it off to another one? If the latter, let's merge and discuss this on another thread (maybe
a JIRA issue?). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message