quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.
Date Mon, 13 Jun 2016 16:38:29 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/28#discussion_r66825014
  
    --- Diff: cli/QuickstepCli.cpp ---
    @@ -150,6 +154,14 @@ DEFINE_bool(initialize_db, false, "If true, initialize a database.");
     DEFINE_bool(print_query, false,
                 "Print each input query statement. This is useful when running a "
                 "large number of queries in a batch.");
    +DEFINE_string(profile_file_name, "",
    --- End diff --
    
    One thing which we can do is generate a default profile name if none is specified. The
default profile name can be something like "quickstep-profile-<timestamp>.prof", so
that name collisions are avoided. That way, we can get rid of the check ``!quickstep::FLAGS_profile_file_name.empty()``
in Line 450. It's ok if we don't do it right away, in which case you can leave a TODO note.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message