quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From navsan <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #28: Add option to enable Google Profiler.
Date Mon, 13 Jun 2016 02:33:39 GMT
Github user navsan commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/28#discussion_r66734229
  
    --- Diff: cli/QuickstepCli.cpp ---
    @@ -335,6 +347,9 @@ int main(int argc, char* argv[]) {
       std::unique_ptr<SqlParserWrapper> parser_wrapper(new SqlParserWrapper());
       std::chrono::time_point<std::chrono::steady_clock> start, end;
     
    +#ifdef QUICKSTEP_ENABLE_GOOGLE_PROFILER
    +  unsigned int query_num = 0;
    --- End diff --
    
    See the latest version. There's a bool variable declared here instead. We need the declaration
to be outside the for loop, so there'll still be a code change here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message