quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #27: QUICKSTEP-18: Allow BasicColumnStoreTu...
Date Sun, 12 Jun 2016 19:30:20 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725967
  
    --- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
    @@ -671,6 +688,8 @@ void BasicColumnStoreTupleStorageSubBlock::shiftNullBitmaps(
     // total size of tuples contained in this sub-block. It could be done with
     // less memory, although the implementation would be more complex.
     bool BasicColumnStoreTupleStorageSubBlock::rebuildInternal() {
    +  DEBUG_ASSERT(sort_specified_);
    --- End diff --
    
    Please use `DCHECK` from `glog`. `DEBUG_ASSERT` has been depreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message