quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #27: QUICKSTEP-18: Allow BasicColumnStoreTu...
Date Sun, 12 Jun 2016 19:25:18 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/27#discussion_r66725906
  
    --- Diff: storage/BasicColumnStoreTupleStorageSubBlock.cpp ---
    @@ -473,10 +483,10 @@ void BasicColumnStoreTupleStorageSubBlock::setAttributeValueInPlaceTyped(
     bool BasicColumnStoreTupleStorageSubBlock::deleteTuple(const tuple_id tuple) {
       DEBUG_ASSERT(hasTupleWithID(tuple));
     
    -  if (!column_null_bitmaps_.elementIsNull(sort_column_id_)) {
    -    if (column_null_bitmaps_[sort_column_id_].getBit(tuple)) {
    -      --(header_->nulls_in_sort_column);
    -    }
    +  if (sort_specified_
    +      && !column_null_bitmaps_.elementIsNull(sort_column_id_)
    +      && column_null_bitmaps_[sort_column_id_].getBit(tuple)) {
    --- End diff --
    
    Code style:
    
    Could we be consistent about where to wrap a line for a conditional expression? I think
most of time we use the following style. Thanks!
    
    ```
      if (aaa &&
          bbb &&
          cc)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message