quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Date Sun, 12 Jun 2016 04:56:59 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66716091
  
    --- Diff: query_execution/Foreman.hpp ---
    @@ -22,46 +22,40 @@
     #include <memory>
     #include <vector>
     
    -#include "catalog/CatalogTypedefs.hpp"
     #include "query_execution/ForemanLite.hpp"
    -#include "query_execution/QueryContext.hpp"
    -#include "query_execution/QueryExecutionState.hpp"
    -#include "query_execution/QueryExecutionTypedefs.hpp"
    -#include "query_execution/WorkOrdersContainer.hpp"
    -#include "query_execution/WorkerMessage.hpp"
    -#include "relational_operators/RelationalOperator.hpp"
    -#include "relational_operators/WorkOrder.hpp"
    -#include "storage/StorageBlockInfo.hpp"
    -#include "utility/DAG.hpp"
    +#include "query_execution/PolicyEnforcer.hpp"
     #include "utility/Macros.hpp"
     
    -#include "glog/logging.h"
    -#include "gtest/gtest_prod.h"
    +#include "gflags/gflags.h"
     
    +#include "tmb/id_typedefs.h"
     #include "tmb/message_bus.h"
     
     namespace quickstep {
     
    +DECLARE_uint64(min_load_per_worker);
    --- End diff --
    
    Then, we could remove this line. Since it is only used within the same class, we don't
need to declare it in the header file.
    
    Defining it in the source file is good enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message