quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Date Sun, 12 Jun 2016 04:55:09 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66716082
  
    --- Diff: query_execution/Foreman.cpp ---
    @@ -22,355 +22,189 @@
     #include <utility>
     #include <vector>
     
    -#include "catalog/CatalogDatabase.hpp"
    -#include "catalog/CatalogRelation.hpp"
    -#include "catalog/CatalogTypedefs.hpp"
    -#include "catalog/PartitionScheme.hpp"
    -#include "query_execution/QueryContext.hpp"
    -#include "query_execution/QueryExecutionMessages.pb.h"
    +#include "query_execution/AdmitRequestMessage.hpp"
     #include "query_execution/QueryExecutionTypedefs.hpp"
     #include "query_execution/QueryExecutionUtil.hpp"
     #include "query_execution/WorkerDirectory.hpp"
     #include "query_execution/WorkerMessage.hpp"
    -#include "relational_operators/RebuildWorkOrder.hpp"
    -#include "relational_operators/RelationalOperator.hpp"
    -#include "relational_operators/WorkOrder.hpp"
    -#include "storage/InsertDestination.hpp"
    -#include "storage/StorageBlock.hpp"
    -#include "storage/StorageBlockInfo.hpp"
     #include "threading/ThreadUtil.hpp"
    +#include "utility/EqualsAnyConstant.hpp"
     #include "utility/Macros.hpp"
     
    +#include "gflags/gflags.h"
     #include "glog/logging.h"
     
     #include "tmb/message_bus.h"
     #include "tmb/tagged_message.h"
     
     using std::move;
    -using std::pair;
     using std::size_t;
    +using std::unique_ptr;
     using std::vector;
     
     namespace quickstep {
     
    -void Foreman::initialize() {
    +DEFINE_uint64(min_load_per_worker, 2, "The minimum load defined as the number "
    --- End diff --
    
    If you are curious about the distributed query execution, check out this branch: https://github.com/apache/incubator-quickstep/tree/distributed-exe-gen-test/query_execution.
    
    In short, after moving the `gflag` variable to `ForemanLite`, `ForemanDistributed`, a
derived class of `ForemanLite`, could use this variable. We use the term `Worker`, which consists
of `Shiftboss`, `StorageManager`, and a thread pool, running as an independent `OS` process
that executes `WorkOrder`s from `ForemanDistributed`. `Shiftboss` is a final derived class
of `Thread`.
    
    The load of `Worker` is controlled by `ForemanDistributed`, so it is perfect to set in
`ForemanLite`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message