quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Date Sat, 11 Jun 2016 23:59:53 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66713553
  
    --- Diff: query_execution/Foreman.cpp ---
    @@ -22,355 +22,189 @@
     #include <utility>
     #include <vector>
     
    -#include "catalog/CatalogDatabase.hpp"
    -#include "catalog/CatalogRelation.hpp"
    -#include "catalog/CatalogTypedefs.hpp"
    -#include "catalog/PartitionScheme.hpp"
    -#include "query_execution/QueryContext.hpp"
    -#include "query_execution/QueryExecutionMessages.pb.h"
    +#include "query_execution/AdmitRequestMessage.hpp"
     #include "query_execution/QueryExecutionTypedefs.hpp"
     #include "query_execution/QueryExecutionUtil.hpp"
     #include "query_execution/WorkerDirectory.hpp"
     #include "query_execution/WorkerMessage.hpp"
    -#include "relational_operators/RebuildWorkOrder.hpp"
    -#include "relational_operators/RelationalOperator.hpp"
    -#include "relational_operators/WorkOrder.hpp"
    -#include "storage/InsertDestination.hpp"
    -#include "storage/StorageBlock.hpp"
    -#include "storage/StorageBlockInfo.hpp"
     #include "threading/ThreadUtil.hpp"
    +#include "utility/EqualsAnyConstant.hpp"
     #include "utility/Macros.hpp"
     
    +#include "gflags/gflags.h"
     #include "glog/logging.h"
     
     #include "tmb/message_bus.h"
     #include "tmb/tagged_message.h"
     
     using std::move;
    -using std::pair;
     using std::size_t;
    +using std::unique_ptr;
     using std::vector;
     
     namespace quickstep {
     
    -void Foreman::initialize() {
    +DEFINE_uint64(min_load_per_worker, 2, "The minimum load defined as the number "
    --- End diff --
    
    I don't understand this. How can it help if I move the gflag variable to ForemanLite?
Both ForemanDistributed and ShiftBoss are the derived classes of the base class ForemanLite,
correct? I am saying that the threshold described by this flag should be different for ForemanDistributed
and ShiftBoss. In that case it makes more sense for both the classes to have their own gflag
variable. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message