quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pateljm <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Date Fri, 10 Jun 2016 23:00:18 GMT
Github user pateljm commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66692255
  
    --- Diff: cli/QuickstepCli.cpp ---
    @@ -323,13 +326,20 @@ int main(int argc, char* argv[]) {
                                        worker_client_ids,
                                        worker_numa_nodes);
     
    -  foreman.setWorkerDirectory(&worker_directory);
    +  Foreman foreman(main_thread_client_id,
    +                  &worker_directory,
    +                  &bus,
    +                  query_processor->getDefaultDatabase(),
    +                  query_processor->getStorageManager(),
    +                  num_numa_nodes_system);
     
       // Start the worker threads.
       for (Worker &worker : workers) {
         worker.start();
       }
     
    +  foreman.start();
    --- End diff --
    
    @zuyu Your suggestion makes sense to make the distributed version easier. Thanks both
of you for a good discussion! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message