quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #14: QUICKSTEP-8: Long running Foreman thread
Date Fri, 10 Jun 2016 22:58:32 GMT
Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/14
  
    @hbdeshmukh I did one pass, and I would highlight two things:
     * Please remove some duplicated doxygen in operator header files, as a part of incorrect
auto-rebasing.
     * Emphasis the argument order for `query_id` and `op_index`. We would always put the
former first, and then latter.
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message