quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #14: QUICKSTEP-8: Long running Foreman thre...
Date Fri, 10 Jun 2016 16:22:07 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/14#discussion_r66641533
  
    --- Diff: storage/InsertDestination.cpp ---
    @@ -60,25 +60,28 @@ InsertDestination::InsertDestination(const CatalogRelationSchema &relation,
                                          const StorageBlockLayout *layout,
                                          StorageManager *storage_manager,
                                          const std::size_t relational_op_index,
    +                                     const std::size_t query_id,
    --- End diff --
    
    I think this is really reading too much into ordering of parameters. It doesn't make any
crucial difference. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message