quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pateljm <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #17: Serialized WorkOrders as proto.
Date Thu, 09 Jun 2016 13:22:56 GMT
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/17
  
    @zuyu -- Nice! LGTM. As you say, will have to rework the window aggregation branch later,
but sounds like the changes are straightforward. To that effect, could you add a guide for
what new operator writers need to follow w.r.t. the proto. This could go in ` query_execution/WorkOrderProtosContainer.hpp`
(but you may have a better location for that comment). Ok -- to do that as a separate PR if
you find that more convenient.   
    
    Can you merge the conflict -- sorry that may have been caused by the merge of PR#19.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message