quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #13: Add option to build using shared libra...
Date Thu, 09 Jun 2016 01:27:12 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/13#discussion_r66369808
  
    --- Diff: cli/CMakeLists.txt ---
    @@ -30,6 +30,12 @@ if(LIBNUMA_FOUND)
       set(QUICKSTEP_HAVE_LIBNUMA TRUE)
     endif()
     
    +if (BUILD_SHARED_LIBS)
    +  set(GFLAGS_LIB_NAME gflags_nothreads-shared)
    +else()
    +  set(GFLAGS_LIB_NAME gflags_nothreads-static)
    +endif()
    --- End diff --
    
    Try remove this part, as I believe `cmake` is smart enough to figure out the variable
`GFLAGS_LIB_NAME`.
    
    Otherwise, try use `options(GFLAGS_LIB_NAME ...)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message