quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #10: Reorder query id parameter in various ...
Date Wed, 08 Jun 2016 18:36:37 GMT
Github user hbdeshmukh commented on a diff in the pull request:

    --- Diff: query_optimizer/tests/ExecutionHeuristics_unittest.cpp ---
    @@ -75,12 +75,12 @@ class ExecutionHeuristicsTest : public ::testing::Test {
         std::vector<attribute_id> build_attribute_ids;
         QueryPlan::DAGNodeIndex build_operator_index =
    -        query_plan->addRelationalOperator(new BuildHashOperator(*build_relation,
    +        query_plan->addRelationalOperator(new BuildHashOperator(0,  /* dummy query
ID */
    --- End diff --
    This suggestion will require some work as there are a number of unit tests which need
this change.  The dummy query ID flag is informative as of now. We can come back to it later,
if that's fine. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message