quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zuyu <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request #10: Reorder query id parameter in various ...
Date Wed, 08 Jun 2016 17:08:09 GMT
Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/10#discussion_r66296664
  
    --- Diff: query_optimizer/ExecutionGenerator.cpp ---
    @@ -1499,13 +1504,13 @@ void ExecutionGenerator::convertSort(const P::SortPtr &physical_sort)
{
       const CatalogRelationInfo *input_relation_info =
           findRelationInfoOutputByPhysical(physical_sort->input());
       const QueryPlan::DAGNodeIndex run_generator_index =
    -      execution_plan_->addRelationalOperator(
    -          new SortRunGenerationOperator(*input_relation_info->relation,
    -                                        *initial_runs_relation,
    -                                        initial_runs_destination_id,
    -                                        sort_run_gen_config_id,
    -                                        input_relation_info->isStoredRelation(),
    -                                        query_handle_->query_id()));
    +      execution_plan_->addRelationalOperator(new SortRunGenerationOperator(
    +          query_handle_->query_id(),
    +          *input_relation_info->relation,
    +          *initial_runs_relation,
    +          initial_runs_destination_id,
    +          sort_run_gen_config_id,
    +          input_relation_info->isStoredRelation()));
    --- End diff --
    
    FYI, the original style of wrapping a line is acceptable based on our code style with
at most 120 characters per line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message