quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pateljm <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #8: Added query id in all the operators and the wo...
Date Tue, 07 Jun 2016 13:25:17 GMT
Github user pateljm commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/8
  
    @hbdeshmukh: Zuyu (@zuyu) makes an excellent point, IMHO. The code would be more readable
if we put the query_id first. This argument is somewhat inconsistently placed in the argument
list  right now (e.g. in `DropTableOperator` it is the second argument, and in most other
it is the last). 
    
    @hbdeshmukh: How about doing this in a separate PR if it is too much to do it in this
one? But, if possible, would be good to create that PR soon. I can pair with you if needed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message