quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbdeshmukh <...@git.apache.org>
Subject [GitHub] incubator-quickstep issue #6: Minor Improvements in Storage.
Date Wed, 01 Jun 2016 15:55:58 GMT
Github user hbdeshmukh commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/6
  
    I am not sure if a conversation on a GitHub PR is acceptable. So I will not add more comments
for now. There seem to be some inconsistencies while using ``DCHECK`` and ``CHECK`` macros
in the code change. Please let me know once you address them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message