quickstep-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pateljm <...@git.apache.org>
Subject [GitHub] incubator-quickstep pull request: Added BlockLocator.
Date Sat, 28 May 2016 23:41:47 GMT
Github user pateljm commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/3#discussion_r64995764
  
    --- Diff: query_execution/QueryExecutionTypedefs.hpp ---
    @@ -66,6 +67,19 @@ enum QueryExecutionMessageType : message_type_id {
       kRebuildWorkOrderMessage,  // From Foreman to Worker.
       kRebuildWorkOrderCompleteMessage,  // From Worker to Foreman.
       kPoisonMessage,  // From the CLI shell to Foreman, then from Foreman to Workers.
    +
    --- End diff --
    
    Would you consider sorting this list to improve readability? 
    
    I know the previous enum was also not sorted and probably should be too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message