quickstep-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jign...@apache.org
Subject [02/12] incubator-quickstep git commit: Adds regex to specify 16.+ versions of Darwin
Date Tue, 07 Feb 2017 23:46:22 GMT
Adds regex to specify 16.+ versions of Darwin

Before this change, only one recent version of Darwin was correcly
having the compiler flags modified to allow for deprecated syscalls.
After this change, all versions of Darwin 16+ should correcly apply the
cxx flags. This is still a somewhat temporary fix because the real
issue (replacing the deprecated calls) has not been addressed.


Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/ec76096b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/ec76096b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/ec76096b

Branch: refs/heads/reduce-group-by-attrs
Commit: ec76096bc766c1a2c0f21929b3a998c51e417208
Parents: 669a74c
Author: cramja <marc.spehlmann@gmail.com>
Authored: Tue Feb 7 11:28:39 2017 -0600
Committer: cramja <marc.spehlmann@gmail.com>
Committed: Tue Feb 7 14:33:41 2017 -0600

----------------------------------------------------------------------
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/ec76096b/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e74a274..918069c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -299,7 +299,7 @@ else()
   # builds to fail. As a short-term workaround for now, we turn off deprecated
   # warnings so that they do not cause build failures anymore.
   # TODO: Remove this workaround by fixing the protobuf_cmake and glog_cmake.
-  if (${CMAKE_SYSTEM} MATCHES "Darwin-16.1.0")
+  if (${CMAKE_SYSTEM} MATCHES "Darwin-16.[0-9]*.[0-9]*")
     if (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
       CHECK_CXX_COMPILER_FLAG("-Wno-error=deprecated-declarations" COMPILER_HAS_WNO_DEPRECATED)
       if (COMPILER_HAS_WNO_DEPRECATED)


Mime
View raw message