Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B26B2200BD3 for ; Tue, 6 Dec 2016 18:54:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B1089160B1B; Tue, 6 Dec 2016 17:54:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0417F160B17 for ; Tue, 6 Dec 2016 18:54:52 +0100 (CET) Received: (qmail 19527 invoked by uid 500); 6 Dec 2016 17:54:52 -0000 Mailing-List: contact commits-help@quickstep.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quickstep.incubator.apache.org Delivered-To: mailing list commits@quickstep.incubator.apache.org Received: (qmail 19512 invoked by uid 99); 6 Dec 2016 17:54:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 17:54:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 93B87C8911 for ; Tue, 6 Dec 2016 17:54:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.218 X-Spam-Level: X-Spam-Status: No, score=-6.218 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id cK2oHsvgxJcy for ; Tue, 6 Dec 2016 17:54:49 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1D92E5F2EF for ; Tue, 6 Dec 2016 17:54:48 +0000 (UTC) Received: (qmail 19383 invoked by uid 99); 6 Dec 2016 17:54:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 17:54:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C20D2DFFAB; Tue, 6 Dec 2016 17:54:34 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: hakanmemisoglu@apache.org To: commits@quickstep.incubator.apache.org Message-Id: <31db5d7c6f5a4fb48bd9a24c6f3da0b6@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: incubator-quickstep git commit: QUICKSTEP-65 Fix Quickstep build failure on Mac OSX 10.12 by turning off deprecation errors Date: Tue, 6 Dec 2016 17:54:34 +0000 (UTC) archived-at: Tue, 06 Dec 2016 17:54:53 -0000 Repository: incubator-quickstep Updated Branches: refs/heads/master b949c5045 -> 6ae0cdd3d QUICKSTEP-65 Fix Quickstep build failure on Mac OSX 10.12 by turning off deprecation errors Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/6ae0cdd3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/6ae0cdd3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/6ae0cdd3 Branch: refs/heads/master Commit: 6ae0cdd3d5db40febc98be00ce94baeed31ba680 Parents: b949c50 Author: Saket Saurabh Authored: Tue Dec 6 09:53:57 2016 -0600 Committer: Saket Saurabh Committed: Tue Dec 6 10:05:42 2016 -0600 ---------------------------------------------------------------------- CMakeLists.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/6ae0cdd3/CMakeLists.txt ---------------------------------------------------------------------- diff --git a/CMakeLists.txt b/CMakeLists.txt index 391cb26..4dcc56a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -291,6 +291,25 @@ else() endif() endif() + # OSX 10.12 has deprecated certain system-level APIs which causes protobuf & glog + # builds to fail. As a short-term workaround for now, we turn off deprecated + # warnings so that they do not cause build failures anymore. + # TODO: Remove this workaround by fixing the protobuf_cmake and glog_cmake. + if (${CMAKE_SYSTEM} MATCHES "Darwin-16.1.0") + if (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang") + CHECK_CXX_COMPILER_FLAG("-Wno-error=deprecated-declarations" COMPILER_HAS_WNO_DEPRECATED) + if (COMPILER_HAS_WNO_DEPRECATED) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error=deprecated-declarations") + endif() + endif() + if(CMAKE_COMPILER_IS_GNUCXX) + CHECK_CXX_COMPILER_FLAG("-Wno-deprecated-declarations" COMPILER_HAS_WNO_DEPRECATED) + if (COMPILER_HAS_WNO_DEPRECATED) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-declarations") + endif() + endif() + endif() + # One of the protobuf headers includes a nested anonymous union within # another anonymous type. Ordinarily we work around this by compiling the # protobuf libraries themselves with "-Wno-nested-anon-types" and including