Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9D2A9200ACA for ; Thu, 9 Jun 2016 23:56:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9BCA8160A5C; Thu, 9 Jun 2016 21:56:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E086B160A29 for ; Thu, 9 Jun 2016 23:56:18 +0200 (CEST) Received: (qmail 56287 invoked by uid 500); 9 Jun 2016 21:56:18 -0000 Mailing-List: contact commits-help@quickstep.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quickstep.incubator.apache.org Delivered-To: mailing list commits@quickstep.incubator.apache.org Received: (qmail 56278 invoked by uid 99); 9 Jun 2016 21:56:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 21:56:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B9A3CC0D4B for ; Thu, 9 Jun 2016 21:56:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Ra0lI39pwF6n for ; Thu, 9 Jun 2016 21:56:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 142CF5F19D for ; Thu, 9 Jun 2016 21:56:14 +0000 (UTC) Received: (qmail 56255 invoked by uid 99); 9 Jun 2016 21:56:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 21:56:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 20758E0107; Thu, 9 Jun 2016 21:56:14 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: zuyuz@apache.org To: commits@quickstep.incubator.apache.org Date: Thu, 09 Jun 2016 21:56:15 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/6] incubator-quickstep git commit: Fixed a potential segfault with CompressedBlockBuilder. archived-at: Thu, 09 Jun 2016 21:56:19 -0000 Fixed a potential segfault with CompressedBlockBuilder. Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/eebb4644 Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/eebb4644 Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/eebb4644 Branch: refs/heads/work-order-serialization Commit: eebb4644f195fd82b28e77aafcf60344c33d6197 Parents: 096abe2 Author: Jianqiao Zhu Authored: Thu Jun 9 00:43:16 2016 -0500 Committer: Zuyu Zhang Committed: Thu Jun 9 10:52:12 2016 -0700 ---------------------------------------------------------------------- storage/CompressedBlockBuilder.cpp | 3 +++ 1 file changed, 3 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/eebb4644/storage/CompressedBlockBuilder.cpp ---------------------------------------------------------------------- diff --git a/storage/CompressedBlockBuilder.cpp b/storage/CompressedBlockBuilder.cpp index 4a181eb..1ca0c07 100644 --- a/storage/CompressedBlockBuilder.cpp +++ b/storage/CompressedBlockBuilder.cpp @@ -321,6 +321,9 @@ void CompressedBlockBuilder::buildCompressedColumnStoreTupleStorageSubBlock(void bool CompressedBlockBuilder::addTupleInternal(Tuple *candidate_tuple) { DEBUG_ASSERT(candidate_tuple->size() == relation_.size()); + // Ensure that the tuple is the owner of its values. + candidate_tuple->ensureLiteral(); + // Modify dictionaries and maximum integers to reflect the new tuple's // values. Keep track of what has changed in case a rollback is needed. vector modified_dictionaries;