Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 00732200B47 for ; Thu, 9 Jun 2016 03:09:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F37EF160A2E; Thu, 9 Jun 2016 01:09:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A414160A5C for ; Thu, 9 Jun 2016 03:09:35 +0200 (CEST) Received: (qmail 37944 invoked by uid 500); 9 Jun 2016 01:09:34 -0000 Mailing-List: contact commits-help@quickstep.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quickstep.incubator.apache.org Delivered-To: mailing list commits@quickstep.incubator.apache.org Received: (qmail 37925 invoked by uid 99); 9 Jun 2016 01:09:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 01:09:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C8940180E5F for ; Thu, 9 Jun 2016 01:09:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0TRF6upqgvHP for ; Thu, 9 Jun 2016 01:09:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 12C7860CE7 for ; Thu, 9 Jun 2016 01:09:30 +0000 (UTC) Received: (qmail 37605 invoked by uid 99); 9 Jun 2016 01:09:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 01:09:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 23BE1E094D; Thu, 9 Jun 2016 01:09:30 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: hbdeshmukh@apache.org To: commits@quickstep.incubator.apache.org Date: Thu, 09 Jun 2016 01:09:33 -0000 Message-Id: <6d86e20b91fa44918ce095301f6bd6ab@git.apache.org> In-Reply-To: <037698398b984510870e9720ce07e164@git.apache.org> References: <037698398b984510870e9720ce07e164@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [04/48] incubator-quickstep git commit: Fixes bug which disallows the creation of BITWEAVING_H indices. (#204) archived-at: Thu, 09 Jun 2016 01:09:36 -0000 Fixes bug which disallows the creation of BITWEAVING_H indices. (#204) Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/f18c8d1b Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/f18c8d1b Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/f18c8d1b Branch: refs/heads/query-manager-used-in-foreman Commit: f18c8d1b59fc87bf819ce547ee5929d9fce810c6 Parents: 4f7725f Author: Marc S Authored: Sun May 1 17:14:20 2016 -0500 Committer: Zuyu Zhang Committed: Wed Jun 8 11:57:40 2016 -0700 ---------------------------------------------------------------------- parser/ParseIndexProperties.hpp | 2 +- parser/tests/Index.test | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/f18c8d1b/parser/ParseIndexProperties.hpp ---------------------------------------------------------------------- diff --git a/parser/ParseIndexProperties.hpp b/parser/ParseIndexProperties.hpp index 9ca1419..2cb5df9 100644 --- a/parser/ParseIndexProperties.hpp +++ b/parser/ParseIndexProperties.hpp @@ -220,7 +220,7 @@ class BitWeavingIndexProperties : public IndexProperties { } const std::string key = ToLower(key_value.key()->value()); const std::string value = ToLower( - static_cast(key_value).key()->value()); + static_cast(key_value).value()->value()); if (key.compare(kBitWeavingType) == 0) { if (value.compare("h") == 0) { index_sub_block_description_->set_sub_block_type(IndexSubBlockDescription::BITWEAVING_H); http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/f18c8d1b/parser/tests/Index.test ---------------------------------------------------------------------- diff --git a/parser/tests/Index.test b/parser/tests/Index.test index 605768b..39cd523 100644 --- a/parser/tests/Index.test +++ b/parser/tests/Index.test @@ -66,3 +66,14 @@ CREATE INDEX bwIndex ON test(int_col) USING bitweaving; CreateIndexStatement[index_name=bwIndex,relation_name=test,index_type=bitweaving] +-attribute_list= +-AttributeReference[attribute_name=int_col] +== +CREATE INDEX bwhIndex ON test(int_col) USING bitweaving (TYPE H); +-- +CreateIndexStatement[index_name=bwhIndex,relation_name=test, + index_type=bitweaving] ++-attribute_list= +| +-AttributeReference[attribute_name=int_col] ++-index_property_list= + +-IndexProperties + +-index_property=KeyStringValue[key=TYPE] + +-value=String[value=H]