Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06DF3200B2B for ; Tue, 28 Jun 2016 19:43:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 05B20160A6F; Tue, 28 Jun 2016 17:43:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 56E09160A28 for ; Tue, 28 Jun 2016 19:43:55 +0200 (CEST) Received: (qmail 1976 invoked by uid 500); 28 Jun 2016 17:43:54 -0000 Mailing-List: contact commits-help@quickstep.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@quickstep.incubator.apache.org Delivered-To: mailing list commits@quickstep.incubator.apache.org Received: (qmail 1967 invoked by uid 99); 28 Jun 2016 17:43:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 17:43:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 096F8C0439 for ; Tue, 28 Jun 2016 17:43:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.646 X-Spam-Level: X-Spam-Status: No, score=-4.646 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xlY_yV3XWkfv for ; Tue, 28 Jun 2016 17:43:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 473AD5F366 for ; Tue, 28 Jun 2016 17:43:52 +0000 (UTC) Received: (qmail 1934 invoked by uid 99); 28 Jun 2016 17:43:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2016 17:43:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 575E7E0B66; Tue, 28 Jun 2016 17:43:51 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: shixuan@apache.org To: commits@quickstep.incubator.apache.org Date: Tue, 28 Jun 2016 17:43:53 -0000 Message-Id: <08bce90839234829afb3116637fea830@git.apache.org> In-Reply-To: <07b19de01623423bbd4e6c5bc4d7dff3@git.apache.org> References: <07b19de01623423bbd4e6c5bc4d7dff3@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [3/4] incubator-quickstep git commit: Added move semantic in the constructor of window plan archived-at: Tue, 28 Jun 2016 17:43:56 -0000 Added move semantic in the constructor of window plan Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/cfc89d65 Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/cfc89d65 Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/cfc89d65 Branch: refs/heads/move-semantic-in-window-plan Commit: cfc89d65a77e43d2b2095f8c9db62baf8922f8b8 Parents: 79b1014 Author: shixuan-fan Authored: Tue Jun 28 15:42:09 2016 +0000 Committer: shixuan-fan Committed: Tue Jun 28 15:42:09 2016 +0000 ---------------------------------------------------------------------- query_optimizer/resolver/Resolver.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/cfc89d65/query_optimizer/resolver/Resolver.cpp ---------------------------------------------------------------------- diff --git a/query_optimizer/resolver/Resolver.cpp b/query_optimizer/resolver/Resolver.cpp index 1eb6d86..95096c9 100644 --- a/query_optimizer/resolver/Resolver.cpp +++ b/query_optimizer/resolver/Resolver.cpp @@ -228,9 +228,9 @@ struct Resolver::QueryAggregationInfo { }; struct Resolver::WindowPlan { - WindowPlan(const E::WindowInfo &window_info_in, + WindowPlan(E::WindowInfo &&window_info_in, const L::LogicalPtr &logical_plan_in) - : window_info(window_info_in), + : window_info(std::move(window_info_in)), logical_plan(logical_plan_in) {} const E::WindowInfo window_info; @@ -1032,7 +1032,7 @@ L::LogicalPtr Resolver::resolveSelect( L::LogicalPtr sorted_logical_plan = resolveSortInWindow(logical_plan, resolved_window); - WindowPlan window_plan(resolved_window, sorted_logical_plan); + WindowPlan window_plan(std::move(resolved_window), sorted_logical_plan); sorted_window_map.emplace(window.name()->value(), window_plan); }