quickstep-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jign...@apache.org
Subject [2/3] incubator-quickstep git commit: Fix a potential segfault with CompressedBlockBuilder
Date Thu, 09 Jun 2016 13:07:31 GMT
Fix a potential segfault with CompressedBlockBuilder


Project: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/commit/70ef4101
Tree: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/tree/70ef4101
Diff: http://git-wip-us.apache.org/repos/asf/incubator-quickstep/diff/70ef4101

Branch: refs/heads/master
Commit: 70ef41015585505dc015b1f4816dd48dd5ff2b80
Parents: 55b06fa
Author: Jianqiao Zhu <jianqiao@cs.wisc.edu>
Authored: Thu Jun 9 00:43:16 2016 -0500
Committer: Jignesh Patel <jmp_007@hotmail.com>
Committed: Thu Jun 9 08:06:29 2016 -0500

----------------------------------------------------------------------
 storage/CompressedBlockBuilder.cpp | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-quickstep/blob/70ef4101/storage/CompressedBlockBuilder.cpp
----------------------------------------------------------------------
diff --git a/storage/CompressedBlockBuilder.cpp b/storage/CompressedBlockBuilder.cpp
index 4a181eb..1ca0c07 100644
--- a/storage/CompressedBlockBuilder.cpp
+++ b/storage/CompressedBlockBuilder.cpp
@@ -321,6 +321,9 @@ void CompressedBlockBuilder::buildCompressedColumnStoreTupleStorageSubBlock(void
 bool CompressedBlockBuilder::addTupleInternal(Tuple *candidate_tuple) {
   DEBUG_ASSERT(candidate_tuple->size() == relation_.size());
 
+  // Ensure that the tuple is the owner of its values.
+  candidate_tuple->ensureLiteral();
+
   // Modify dictionaries and maximum integers to reflect the new tuple's
   // values. Keep track of what has changed in case a rollback is needed.
   vector<CompressionDictionaryBuilder*> modified_dictionaries;


Mime
View raw message