quetz-mod_python-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Graham Dumpleton (JIRA)" <j...@apache.org>
Subject [jira] Created: (MODPYTHON-189) repr() for various objects doesn't convert data members correctly.
Date Mon, 11 Sep 2006 10:43:22 GMT
repr() for various objects doesn't convert data members correctly.
------------------------------------------------------------------

                 Key: MODPYTHON-189
                 URL: http://issues.apache.org/jira/browse/MODPYTHON-189
             Project: mod_python
          Issue Type: Bug
          Components: core
    Affects Versions: 3.2.10, 3.3
            Reporter: Graham Dumpleton
            Priority: Minor


The repr() methods of various objects, eg., tableobject, use code like:

            PyString_ConcatAndDel(&s, PyString_FromString("'"));
            PyString_ConcatAndDel(&s, PyString_FromString(elts[i].key));
            PyString_ConcatAndDel(&s, PyString_FromString("': '"));
            PyString_ConcatAndDel(&s, PyString_FromString(elts[i].val));
            PyString_ConcatAndDel(&s, PyString_FromString("'"));

to construct the string. This doesn't though consider that values could have quotes in them.

Instead of outputting quotes and string in between, should use something like:

               t = PyString_FromString(elts[i].val);
               PyString_ConcatAndDel(&s, PyObject_Repr(t));
               Py_XDECREF(t);

Ie., let the repr() routine of the string to quote as appropriate.

Since the repr() outputs of these objects are only used for debugging and can't be used to
reconstruct objects, not too big a deal, but should be addressed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message