qpid-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robbie Gemmell <robbie.gemm...@gmail.com>
Subject Re: [VOTE] Release Apache Qpid Proton 0.27.0
Date Fri, 08 Feb 2019 11:53:24 GMT
I tried the build on F29 and saw the same warning. Trying 0.26.0 this
also occurs, and so it seems it isn't a regression in this release,
but a newer GCC warning.

If I am understanding things correctly the warning is spurious in this
case, aiming to stop you using the source size while copying the
string into the destination not checking the destination size, but in
this case the destination was just allocated using the same size value
and so the length has effectively been checked.

Subsequent googling retured results of a change made to swig as a
result though: https://github.com/swig/swig/pull/1333

Robbie

On Thu, 7 Feb 2019 at 19:50, Ted Ross <tross@redhat.com> wrote:
>
> +1 (assuming the below warning is not a blocker)
> Installed and ran tests on Fedora 29
> Tested against Qpid Dispatch Router
> -Ted
>
> On Thu, Feb 7, 2019 at 1:58 PM Ted Ross <tross@redhat.com> wrote:
>
> > Should have added that I'm running on Fedora 29.  The swig version is
> > swig-3.0.12-21.fc29.
> >
> > On Thu, Feb 7, 2019 at 1:56 PM Ted Ross <tross@redhat.com> wrote:
> >
> >> Still testing, but I saw the following warning during the build.  It
> >> appears to be in SWIG-generated code, so this might not be easy to address.
> >>
> >> [100%] Building C object
> >> python/CMakeFiles/_cproton.dir/CMakeFiles/_cproton.dir/cprotonPYTHON_wrap.c.o
> >> /home/ross/tmp/proton/qpid-proton-0.27.0/build/python/CMakeFiles/_cproton.dir/cprotonPYTHON_wrap.c:
> >> In function ‘SWIG_Python_addvarlink’:
> >> /home/ross/tmp/proton/qpid-proton-0.27.0/build/python/CMakeFiles/_cproton.dir/cprotonPYTHON_wrap.c:23177:9:
> >> warning: ‘strncpy’ specified bound depends on the length of the source
> >> argument [-Wstringop-overflow=]
> >>          strncpy(gv->name,name,size);
> >>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> /home/ross/tmp/proton/qpid-proton-0.27.0/build/python/CMakeFiles/_cproton.dir/cprotonPYTHON_wrap.c:23174:21:
> >> note: length computed here
> >>        size_t size = strlen(name)+1;
> >>                      ^~~~~~~~~~~~
> >> This warning did not halt the build.
> >>
> >> -Ted
> >>
> >> On Thu, Feb 7, 2019 at 12:41 PM Roddie Kieley <rkieley@gmail.com> wrote:
> >>
> >>> +1
> >>>
> >>> I checked out the 0.27.0-rc1 tag on a Fedora 29 box
> >>> - default cmake ../qpid-proton && cmake --build . && ctest
-VV
> >>> - no failures
> >>> - ran all c examples
> >>> - ran all cpp examples w/exception of service_bus
> >>>
> >>> I checked out the 0.27.0-rc1 tag on a 10.11.6 OSX box with Xcode 7.3.1
> >>> - cmake -DCMAKE_OSX_DEPLOYMENT_TARGET=10.11 -DBUILD_RUBY=NO -DBUILD_GO=NO
> >>> -DRUNTIME_CHECK=OFF ../qpid-proton && cmake --build . &&
ctest -VV
> >>> - no failures
> >>> - ran all c examples
> >>> - ran a selection of cpp examples
> >>>
> >>> On Wed, Feb 6, 2019 at 10:32 AM Robbie Gemmell <robbie.gemmell@gmail.com
> >>> >
> >>> wrote:
> >>>
> >>> > Hi folks,
> >>> >
> >>> > I have put together a spin for a Qpid Proton 0.27.0 release, please
> >>> > give it a test out and vote accordingly.
> >>> >
> >>> > The files can be grabbed from:
> >>> > https://dist.apache.org/repos/dist/dev/qpid/proton/0.27.0-rc1/
> >>> >
> >>> > The JIRAs assigned are:
> >>> >
> >>> >
> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313720&version=12344242
> >>> >
> >>> > It is tagged as 0.27.0-rc1.
> >>> >
> >>> > Regards,
> >>> > Robbie
> >>> >
> >>> > ---------------------------------------------------------------------
> >>> > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> >>> > For additional commands, e-mail: users-help@qpid.apache.org
> >>> >
> >>> >
> >>>
> >>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Mime
View raw message