Mailing-List: contact users-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@qpid.apache.org
From: Adel Boutros <Adelboutros@live.com>
To: "users@qpid.apache.org" <users@qpid.apache.org>
Subject: Re: [Qpid Java Broker 6.0.4][Qpid JMS 0.11.1] Setting SSL options to
 AMQP non secured port triggers exception in JMS
Thread-Topic: [Qpid Java Broker 6.0.4][Qpid JMS 0.11.1] Setting SSL options to
 AMQP non secured port triggers exception in JMS
Thread-Index: AQHSfHNQwqDVZz0BB0i7iwVTbJj7iaFT9QiAgAADGQCAAAKHZ4AAA1kAgAAE24I=
Date: Wed, 1 Feb 2017 11:25:33 +0000
Message-ID: <VI1PR0901MB08930E3D6BD55394B27BC428CD4D0@VI1PR0901MB0893.eurprd09.prod.outlook.com>
References: <VI1PR0901MB089367CD872C83E6E9A24527CD4D0@VI1PR0901MB0893.eurprd09.prod.outlook.com>
 <CACsaS94iL8xphqXycgabsGx+iEFeZv-w018c7tDFN51r-qpPvA@mail.gmail.com>
 <CAFitrpTTX4mOjLkEZ8sBtkzdDZc5_PoPr05W1AScUEfg7cRbmQ@mail.gmail.com>
 <VI1PR0901MB08937126613E0137A7FEAEE4CD4D0@VI1PR0901MB0893.eurprd09.prod.outlook.com>,<CACsaS95gPPS9Q_gUZuR5BEXkPFik4FpuY59niG37YMdqZzLCjA@mail.gmail.com>
In-Reply-To: <CACsaS95gPPS9Q_gUZuR5BEXkPFik4FpuY59niG37YMdqZzLCjA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_VI1PR0901MB08930E3D6BD55394B27BC428CD4D0VI1PR0901MB0893_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2017 11:25:33.8366
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR01HT176
X-OriginalArrivalTime: 01 Feb 2017 11:25:42.0591 (UTC) FILETIME=[EC642CF0:01D27C7D]
archived-at: Wed, 01 Feb 2017 11:26:36 -0000

--_000_VI1PR0901MB08930E3D6BD55394B27BC428CD4D0VI1PR0901MB0893_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Understood. Thanks!


Adel

________________________________
From: Rob Godfrey <rob.j.godfrey@gmail.com>
Sent: Wednesday, February 1, 2017 12:08:02 PM
To: users@qpid.apache.org
Subject: Re: [Qpid Java Broker 6.0.4][Qpid JMS 0.11.1] Setting SSL options =
to AMQP non secured port triggers exception in JMS

So - bearing in mind that I was not involved (except very slightly) in the
development of this component, the general reason to throw an exception
rather than to ignore is in case the application programmer has made a
typo, or is expecting some behaviour by setting the option... and the fact
that no action will be taken (because of a typo, or because the option has
no effect in the context) will be a surprise to them.

So, if - for example - you were using an SSL connection, but had supplied
the option verfyHost=3Dfalse (i.e. you had accidentally omitted the i in
verify) then it seems appropriate to throw the exception.

Ideally a better error message could be generated to differentiate between
completely unknown (and thus likely typos) options, and options that are
not valid on this transport (e.g. verifyHost on a non TLS connection), but
overall I think the decision to throw an exception is reasonable.

-- Rob

On 1 February 2017 at 11:57, Adel Boutros <Adelboutros@live.com> wrote:

> So for me there are 2 possible solutions:
>
> 1) Throw exception
>
> 2 ) Ignore the useless parameters
>
>
> So for my general knowledge, why do you think the first one (Which is
> implemented in the JMS client) is the appropriate one?
>
>
> Regards,
>
> Adel
>
> ________________________________
> From: Robbie Gemmell <robbie.gemmell@gmail.com>
> Sent: Wednesday, February 1, 2017 11:47:00 AM
> To: users@qpid.apache.org
> Subject: Re: [Qpid Java Broker 6.0.4][Qpid JMS 0.11.1] Setting SSL option=
s
> to AMQP non secured port triggers exception in JMS
>
> Yep, the client is reporting that a given transport option was not
> able to be applied, in this case because its still using the 'tcp
> transport' and the verifyHost option only applies with the 'ssl
> transport'. As you thought, this occurs before it even attempts to
> make a connection.
>
> Robbie
>
> On 1 February 2017 at 10:35, Rob Godfrey <rob.j.godfrey@gmail.com> wrote:
> > I'm not an expert on the JMS client, but I'm not sure that the
> "verifyHost"
> > option would make any sense on a non-TLS connection (since by definitio=
n
> > you can only verify the host when you receive the TLS certificate).
> >
> > I think the use of the Java Broker here is not important, as I assume
> this
> > fails before it even tries to make a connection,
> >
> > -- Rob
> >
> > On 1 February 2017 at 11:31, Adel Boutros <Adelboutros@live.com> wrote:
> >
> >> Hello,
> >>
> >>
> >> I was playing around SSL/SASL with the Java Broker and noticed that so=
me
> >> of the options which I can pass to the JMS client do not work.
> >>
> >>
> >> For example, if I set the following url for the JMS Connection Factory=
,
> I
> >> will get the below exception. Is this expected behavior?
> >>
> >>
> >> JmsConnectionFactory jmsConnectionFactory =3D new
> >> JmsConnectionFactory("amqp://localhost:5672?transport.
> verifyHost=3Dfalse");
> >> jmsConnectionFactory.createConnection();
> >>
> >>
> >> Caused by: java.lang.IllegalArgumentException:  Not all transport
> options
> >> could be set on the TCP Transport. Check the options are spelled
> correctly.
> >> Unused parameters=3D[{verifyHost=3Dfalse}]. This provider instance can=
not
> be
> >> started.
> >>     at org.apache.qpid.jms.transports.TransportFactory.createTransport=
(
> >> TransportFactory.java:64)
> >>     at org.apache.qpid.jms.transports.TransportFactory.
> >> create(TransportFactory.java:120)
> >>     at org.apache.qpid.jms.provider.amqp.AmqpProvider.connect(
> >> AmqpProvider.java:160)
> >>
> >>
> >> Regards,
> >>
> >> Adel
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>

--_000_VI1PR0901MB08930E3D6BD55394B27BC428CD4D0VI1PR0901MB0893_--