Mailing-List: contact users-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@qpid.apache.org
Subject: Re: [Qpid JMS 0.11.1] Nullpointer exception when providing an empty
 string to the ConnectionFactory
To: users@qpid.apache.org
References: <VI1PR0901MB08932D37EAA369CCA3AA6ED6CD780@VI1PR0901MB0893.eurprd09.prod.outlook.com>
 <faa429c9-b6c8-f722-dbff-005f88ce9e05@gmail.com>
 <VI1PR0901MB08932F88C61FE8ABCD434C58CD780@VI1PR0901MB0893.eurprd09.prod.outlook.com>
From: Timothy Bish <tabish121@gmail.com>
Message-ID: <7c88001b-556a-fba2-0653-2f7cefb7b49f@gmail.com>
Date: Fri, 13 Jan 2017 11:32:04 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <VI1PR0901MB08932F88C61FE8ABCD434C58CD780@VI1PR0901MB0893.eurprd09.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
archived-at: Fri, 13 Jan 2017 16:34:13 -0000

On 01/13/2017 10:08 AM, Adel Boutros wrote:
> Hello Tim,
>
>
> I took a look on the master brunch of the github repo and indeed it seems to be fixed.
>
>
> Regards,
>
> Adel

I made some additional changes to make the error reporting more consistent.

>
> ________________________________
> From: Timothy Bish <tabish121@gmail.com>
> Sent: Friday, January 13, 2017 3:30:59 PM
> To: users@qpid.apache.org
> Subject: Re: [Qpid JMS 0.11.1] Nullpointer exception when providing an empty string to the ConnectionFactory
>
> On 01/13/2017 08:41 AM, Adel Boutros wrote:
>> Hello,
>>
>>
>> While playing around with the JMS API, we noticed that if an empty string is passed to the JmsConnectionFactory constructor, it will throw back a NullPointerException because it tries to access the ".toString" of a NULL URL (See createURI).
>>
>>
>> Do you agree that it would be better to throw an exception which clearly says an empty String URL is forbidden? If yes, I will add a jira issue for it.
>>
>>
>> public static void main(String[] args) {
>>       new JmsConnectionFactory("");
>> }
>>
>>
>> Output
>>
>> ------------
>>
>> Exception in thread "main" java.lang.NullPointerException
>> at org.apache.qpid.jms.JmsConnectionFactory.<init>(JmsConnectionFactory.java:115)
>> at org.apache.qpid.jms.JmsConnectionFactory.<init>(JmsConnectionFactory.java:111)
>>
>>
>> Regards,
>>
>> Adel
>>
> I will take a look at the code again, some things were fixed recently in
> QPIDJMS-245 but there's probably a few more defensive checks needed to
> keep people from hitting this.
>
>
> --
> Tim Bish
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>


-- 
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org