Mailing-List: contact users-help@qpid.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@qpid.apache.org
From: Adel Boutros <Adelboutros@live.com>
To: "users@qpid.apache.org" <users@qpid.apache.org>
Subject: Re: [Proton-c] [0.14.0] [0.15.0] Event_loop injection is very slow
 compared to timer schedule
Thread-Topic: [Proton-c] [0.14.0] [0.15.0] Event_loop injection is very slow
 compared to timer schedule
Thread-Index: AQHSNS3ObTLWehZSoUmhI4QccQJ1S6DF860AgAFUdJI=
Date: Thu, 3 Nov 2016 13:52:23 +0000
Message-ID: <VI1PR0901MB089397E004BA8A6C834BC938CDA30@VI1PR0901MB0893.eurprd09.prod.outlook.com>
References: <VI1PR0901MB0893460D30BC085A83F26DBBCDA00@VI1PR0901MB0893.eurprd09.prod.outlook.com>,<1478107920.5658.80.camel@redhat.com>
In-Reply-To: <1478107920.5658.80.camel@redhat.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_VI1PR0901MB089397E004BA8A6C834BC938CDA30VI1PR0901MB0893_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2016 13:52:23.4915
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT034
X-OriginalArrivalTime: 03 Nov 2016 13:52:26.0174 (UTC) FILETIME=[828ED5E0:01D235D9]
archived-at: Thu, 03 Nov 2016 13:52:59 -0000

--_000_VI1PR0901MB089397E004BA8A6C834BC938CDA30VI1PR0901MB0893_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hello Alan,


Issue created and test case attached in the JIRA. You need to have a runnin=
g broker for the code to run. The functor just closes the connection and it=
 takes 1.15 seconds for the "on_connection_closed" to be called. The timer =
is started when the functor code is called.


https://issues.apache.org/jira/browse/PROTON-1339


PS: If the fix is patchable and appliable on 0.14.0, I would like to apply =
it locally.


Regards,

Adel

________________________________
From: Alan Conway <aconway@redhat.com>
Sent: Wednesday, November 2, 2016 6:32:00 PM
To: users@qpid.apache.org
Subject: Re: [Proton-c] [0.14.0] [0.15.0] Event_loop injection is very slow=
 compared to timer schedule

On Wed, 2016-11-02 at 17:28 +0000, Adel Boutros wrote:
> Hello,
>
>
> In Proton 0.12.2, we were able to inject events from other threads to
> the messaging_handler thread by calling timer.schedule indefinitely
> and queues storing messages to send.
>
>
> With Proton 0.14.0, We have implemented
> proton::thread_safe::event_loop() which should replace the above
> timer.schedule.
>
>
> We have noticed our unit tests are 1 000 times slower with the event
> loop mechanism

Yikes! Please open a JIRA with a test program, I will look at it right
away. I am currently working on improvements to the underlying IO
driver so this is well timed. Better performance metrics is also a hot
topic right now.

> Are you aware of such performance regression? How can we analyze it?

Probably not a regression but just a foolish bit of code in the inject
path, I imagine it will be easy to find and fix with such a large
delta. I'll try to get it fixed for the next release.

Cheers,
Alan.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


--_000_VI1PR0901MB089397E004BA8A6C834BC938CDA30VI1PR0901MB0893_--