qpid-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alan Conway <acon...@redhat.com>
Subject Re: RFI for Proton 0.14.0: PROTON-1279, PROTON-1280, PROTON-1281
Date Thu, 11 Aug 2016 17:11:14 GMT
On Thu, 2016-08-11 at 12:22 -0400, Andrew Stitcher wrote:
> I have three very small (almost trivial) changes that allow Proton to
> build and successfully test on FreeBSD 10 with clang/clang++ (the
> native compiler there)
> 
> 1279 is suppressing an unreachable code warning for code where that
> is
> deliberate (it's there in case someone changes the code carelessly)
> 
> 1280 is a tiny (but admittedly arbitrary) tweak to a test to make it
> work on FreeBSD
> 
> 1281 is a small header inclusion bug that doesn't affect
> gcc/libstdc++
> on Linux, but does affect clang/libc++ on FreeBSD (and probably any
> compiler/system using libc++).
> 
> The code changes can be found attached to the bug entries.
> 
> Alan - I'd be grateful if you could have a quick look at these.
> 
> Andrew

All good. For the switch unreachable code error:

> [1] https://issues.apache.org/jira/browse/PROTON-1279

You could avoid the compiler specific fix by converting to int:

    switch (int(t)) { ... default: return "unknown"; }

but I'm ok with the pragma also.
 
> [2] https://issues.apache.org/jira/browse/PROTON-1280
> [3] https://issues.apache.org/jira/browse/PROTON-1281
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Mime
View raw message