Return-Path: X-Original-To: apmail-qpid-users-archive@www.apache.org Delivered-To: apmail-qpid-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA8EF17706 for ; Tue, 30 Sep 2014 13:54:34 +0000 (UTC) Received: (qmail 7456 invoked by uid 500); 30 Sep 2014 13:54:34 -0000 Delivered-To: apmail-qpid-users-archive@qpid.apache.org Received: (qmail 7421 invoked by uid 500); 30 Sep 2014 13:54:34 -0000 Mailing-List: contact users-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@qpid.apache.org Delivered-To: mailing list users@qpid.apache.org Received: (qmail 7079 invoked by uid 99); 30 Sep 2014 13:54:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Sep 2014 13:54:34 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of crolke@redhat.com designates 209.132.183.24 as permitted sender) Received: from [209.132.183.24] (HELO mx3-phx2.redhat.com) (209.132.183.24) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Sep 2014 13:54:28 +0000 Received: from zmail12.collab.prod.int.phx2.redhat.com (zmail12.collab.prod.int.phx2.redhat.com [10.5.83.14]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s8UDs7sa029336 for ; Tue, 30 Sep 2014 09:54:07 -0400 Date: Tue, 30 Sep 2014 09:54:06 -0400 (EDT) From: Chuck Rolke To: users@qpid.apache.org Message-ID: <1106634362.32161821.1412085246080.JavaMail.zimbra@redhat.com> In-Reply-To: <596208724.56081976.1412028072796.JavaMail.zimbra@redhat.com> References: <5426D546.7000706@blueyonder.co.uk> <1412006468.10961.2.camel@pansy.local> <54299E47.4040405@redhat.com> <596208724.56081976.1412028072796.JavaMail.zimbra@redhat.com> Subject: Re: Proton revision 1627945 barfs on cmake -DCMAKE_BUILD_TYPE=Debug .. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.6] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF31 (Linux)/8.0.6_GA_5922) Thread-Topic: Proton revision 1627945 barfs on cmake -DCMAKE_BUILD_TYPE=Debug .. Thread-Index: Xx1Vh6rGRRvyTahevk3h+VRi71Gb/TgQ1EfQ X-Virus-Checked: Checked by ClamAV on apache.org And to be a really good doobie don't forget a Windows build of some sort. -C ----- Original Message ----- > From: "Michael Goulish" > To: users@qpid.apache.org > Sent: Monday, September 29, 2014 6:01:12 PM > Subject: Re: Proton revision 1627945 barfs on cmake -DCMAKE_BUILD_TYPE=Debug .. > > Sorry about that! > ...fixed now, by making it static. > in future, i will test the default build and the debug build. > > > ----- Original Message ----- > > > On 09/29/2014 12:01 PM, Andrew Stitcher wrote: > > On Sat, 2014-09-27 at 16:18 +0100, Fraser Adams wrote: > >> I just updated to r1627945 and when I do > >> cmake -DCMAKE_BUILD_TYPE=Debug .. > >> make > >> > >> I get: > >> > >> Linking C shared library libqpid-proton.so > >> CMakeFiles/qpid-proton.dir/src/codec/codec.c.o: In function > >> `pni_node_fields': > >> /home/fadams/qpid/qpid-trunk/proton/proton-c/src/codec/codec.c:99: > >> undefined reference to `pn_data_node' > > ... > > > > Without investigating fully, this looks like it is related to > > pn_data_node() being inline. I'd guess that in a debug build nothing is > > inlined, but because the function is marked inline no actual routine is > > generated for it. > > > > I think pn_data_node() was marked inline recently - perhaps it is not > > also marked 'static' which I think might give this error. > > I can confirm that marking pn_data_node static does fix the build in > Debug mode. > > > > > Andrew > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org > > For additional commands, e-mail: users-help@qpid.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org > For additional commands, e-mail: users-help@qpid.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org > For additional commands, e-mail: users-help@qpid.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org For additional commands, e-mail: users-help@qpid.apache.org