From users-return-11328-apmail-qpid-users-archive=qpid.apache.org@qpid.apache.org Mon Sep 29 19:05:57 2014 Return-Path: X-Original-To: apmail-qpid-users-archive@www.apache.org Delivered-To: apmail-qpid-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED75B17DC2 for ; Mon, 29 Sep 2014 19:05:56 +0000 (UTC) Received: (qmail 50012 invoked by uid 500); 29 Sep 2014 19:05:56 -0000 Delivered-To: apmail-qpid-users-archive@qpid.apache.org Received: (qmail 49973 invoked by uid 500); 29 Sep 2014 19:05:56 -0000 Mailing-List: contact users-help@qpid.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@qpid.apache.org Delivered-To: mailing list users@qpid.apache.org Received: (qmail 49951 invoked by uid 99); 29 Sep 2014 19:05:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Sep 2014 19:05:56 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of astitcher@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Sep 2014 19:05:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8TJ5PtP029125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 29 Sep 2014 15:05:25 -0400 Received: from [10.18.97.140] ([10.18.97.140]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8TJ5OHV020618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Mon, 29 Sep 2014 15:05:24 -0400 Message-ID: <1412017523.10961.4.camel@pansy.local> Subject: Re: Proton revision 1627945 barfs on cmake -DCMAKE_BUILD_TYPE=Debug .. From: Andrew Stitcher To: users@qpid.apache.org Date: Mon, 29 Sep 2014 15:05:23 -0400 In-Reply-To: <54299E47.4040405@redhat.com> References: <5426D546.7000706@blueyonder.co.uk> <1412006468.10961.2.camel@pansy.local> <54299E47.4040405@redhat.com> Organization: Red Hat Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Virus-Checked: Checked by ClamAV on apache.org On Mon, 2014-09-29 at 14:00 -0400, Ted Ross wrote: > > On 09/29/2014 12:01 PM, Andrew Stitcher wrote: > > On Sat, 2014-09-27 at 16:18 +0100, Fraser Adams wrote: > >> I just updated to r1627945 and when I do > >> cmake -DCMAKE_BUILD_TYPE=Debug .. > >> make > >> > >> I get: > >> > >> Linking C shared library libqpid-proton.so > >> CMakeFiles/qpid-proton.dir/src/codec/codec.c.o: In function > >> `pni_node_fields': > >> /home/fadams/qpid/qpid-trunk/proton/proton-c/src/codec/codec.c:99: > >> undefined reference to `pn_data_node' > > ... > > > > Without investigating fully, this looks like it is related to > > pn_data_node() being inline. I'd guess that in a debug build nothing is > > inlined, but because the function is marked inline no actual routine is > > generated for it. > > > > I think pn_data_node() was marked inline recently - perhaps it is not > > also marked 'static' which I think might give this error. > > I can confirm that marking pn_data_node static does fix the build in > Debug mode. To clarify: When using C99 You must always make inline functions "static inline" anything else is a bug. If you compile your code using gcc or C++ then inline by itself will work (mostly). Andrew --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org For additional commands, e-mail: users-help@qpid.apache.org